Replace sprintf with snprintf

soedinglab · Apr 11, 2023 · 3626bdb · 3626bdb
1 parent 91b8452
commit 3626bdb
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/commons/Debug.h b/src/commons/Debug.h
@@ -149,10 +149,10 @@ class Debug
             }
             char fmtbuffer[32];
             if(exp < 3){
-                int fmtElm = sprintf(fmtbuffer, "%d",  static_cast<int>(id+1));
+                int fmtElm = snprintf(fmtbuffer, sizeof(fmtbuffer), "%d",  static_cast<int>(id+1));
                 line.append(fmtbuffer, fmtElm);
             }else{
-                int fmtElm = sprintf(fmtbuffer, "%.2f", static_cast<float>(id+1)/ static_cast<float>(base));
+                int fmtElm = snprintf(fmtbuffer, sizeof(fmtbuffer), "%.2f", static_cast<float>(id+1)/ static_cast<float>(base));
                 line.append(fmtbuffer, fmtElm);
                 line.push_back(appending);
             }
@@ -244,7 +244,7 @@ class Debug
                             }
                         }
                         char buffer[32];
-                        int n = sprintf(buffer, "%.2f", progress * 100.0f);
+                        int n = snprintf(buffer, sizeof(buffer), "%.2f", progress * 100.0f);
                         line.append("] ");
                         line.append(buffer, n);
                         line.append("% ");

diff --git a/src/commons/Util.cpp b/src/commons/Util.cpp
@@ -654,13 +654,13 @@ std::string SSTR(unsigned long long x) {
 template<>
 std::string SSTR(double x) {
     char buffer[32];
-    int n = sprintf(buffer, "%.3E", x);
+    int n = snprintf(buffer, sizeof(buffer), "%.3E", x);
     return std::string(buffer, n);
 }
 
 template<>
 std::string SSTR(float x) {
     char buffer[32];
-    int n = sprintf(buffer, "%.3f", x);
+    int n = snprintf(buffer, sizeof(buffer), "%.3f", x);
     return std::string(buffer, n);
 }
diff --git a/src/multihit/besthitperset.cpp b/src/multihit/besthitperset.cpp
@@ -101,7 +101,7 @@ public :
         for (size_t i = 0; i < bestEntry->size(); ++i) {
             if (i == 1) {
                 char tmpBuf[15];
-                sprintf(tmpBuf, "%.3E", logCorrectedPval);
+                snprintf(tmpBuf, sizeof(tmpBuf), "%.3E", logCorrectedPval);
                 buffer.append(tmpBuf);
             } else {
                 buffer.append(bestEntry->at(i));