Merge pull request #3 from Hari-07/patchResizeMaxHeight

sodality-tech · Aug 7, 2024 · 92c6238 · 92c6238
2 parents 241a879 + c0b4b5b
commit 92c6238
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/sheet/lib/src/scrollable.dart b/sheet/lib/src/scrollable.dart
@@ -404,7 +404,7 @@ class SheetState extends State<SheetScrollable>
     return newPhysics.shouldReload(oldPhysics);
   }
 
-  bool _shouldUpdatePosition(SheetScrollable oldWidget) {
+  bool _shouldUpdatePositionBasedOnPhysics(SheetScrollable oldWidget) {
     ScrollPhysics? newPhysics =
         widget.physics ?? widget.scrollBehavior?.getScrollPhysics(context);
     ScrollPhysics? oldPhysics = oldWidget.physics ??
@@ -419,6 +419,16 @@ class SheetState extends State<SheetScrollable>
     return widget.controller?.runtimeType != oldWidget.controller?.runtimeType;
   }
 
+  bool _shouldUpdatePositionBasedOnInitialExtent(SheetScrollable oldWidget) {
+    return widget.initialExtent != oldWidget.initialExtent;
+    // return false;
+  }
+
+  bool _shouldUpdatePosition(SheetScrollable oldWidget) {
+    return _shouldUpdatePositionBasedOnPhysics(oldWidget) ||
+        _shouldUpdatePositionBasedOnInitialExtent(oldWidget);
+  }
+
   @override
   void didUpdateWidget(SheetScrollable oldWidget) {
     super.didUpdateWidget(oldWidget);
@@ -775,7 +785,7 @@ class _ScrollSemantics extends SingleChildRenderObjectWidget {
     required this.allowImplicitScrolling,
     required this.semanticChildCount,
     super.child,
-  })  : assert(semanticChildCount == null || semanticChildCount >= 0);
+  }) : assert(semanticChildCount == null || semanticChildCount >= 0);
 
   final ScrollPosition position;
   final bool allowImplicitScrolling;