Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More date format regex corrections #2128

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

pholser
Copy link
Contributor

@pholser pholser commented Jul 5, 2024

  • Previously, a two-digit month of "00" would have been admitted as valid
  • Legitimate year values, e.g. "1899", would have been disallowed.

* Previously, a two-digit month of "00" would have been admitted as valid
* Legitimate year values, e.g. "1899", would have bee disallowed.
@CLAassistant
Copy link

CLAassistant commented Jul 5, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@m1n0 m1n0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Looks good to me.

@m1n0 m1n0 enabled auto-merge (squash) July 8, 2024 18:11
@m1n0 m1n0 merged commit d877fbd into sodadata:main Jul 8, 2024
12 of 14 checks passed
@pholser pholser deleted the date-format-regex-additions-corrections branch July 8, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants