refact: ShouldNotExist is equal to ShouldNotBeNil (ovh#805)

no need to compare zero nor blank value close ovh#732 Signed-off-by: Yvonnick Esnault <[email protected]> --------- Signed-off-by: Yvonnick Esnault <[email protected]>
socotra · Aug 14, 2024 · c90aa1f · c90aa1f
1 parent dce5a19
commit c90aa1f
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/assertions/assertions.go b/assertions/assertions.go
@@ -243,11 +243,9 @@ func ShouldBeNil(actual interface{}, expected ...interface{}) error {
 	return fmt.Errorf("expected: Nil but is wasn't")
 }
 
-// ShouldNotExist receives a single parameter and ensures that it is nil, blank or zero value
+// ShouldNotExist receives a single parameter and ensures that it is nil
 func ShouldNotExist(actual interface{}, expected ...interface{}) error {
-	if ShouldBeNil(actual) != nil ||
-		ShouldBeBlank(actual) != nil ||
-		ShouldBeZeroValue(actual) != nil {
+	if ShouldBeNil(actual) != nil {
 		return fmt.Errorf("expected not exist but it was")
 	}
 	return nil