Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry2 #336

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Poetry2 #336

merged 5 commits into from
Jan 28, 2025

Conversation

AMontagu
Copy link
Collaborator

@AMontagu AMontagu commented Jan 7, 2025

No description provided.

@AMontagu AMontagu requested a review from legau January 7, 2025 13:57
pyproject.toml Outdated
requires-python = ">=3.10"

[tool.poetry]
package-mode = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be true

@AMontagu
Copy link
Collaborator Author

@legau chen putting it back it doesn't work and I don't know why. Can you have a look on it ?

@legau
Copy link
Contributor

legau commented Jan 24, 2025

I suggest migrating to uv, Poetry v1 and v2 are incompatible in their lockfiles. It would be less painful to use another tool

@AMontagu
Copy link
Collaborator Author

@legau what do you mean incompatible ?

I mean it could be a good options but I never use uv and don't know if it match all the need we actually have.

Look like what was not working on my local machine work on CI. Can you test it in local ?

@AMontagu
Copy link
Collaborator Author

@legau Seem the version 2.0.0 had a bug fixed on 2.0.1 and I now need to copy the folder but everything work fine.

Can you merge it ?

@legau legau merged commit 8d84fb1 into master Jan 28, 2025
12 checks passed
@legau legau deleted the poetry2 branch January 28, 2025 12:01
nohzafk pushed a commit to nohzafk/django-socio-grpc that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants