Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value/not working update default grpc value #258

Merged

Conversation

AMontagu
Copy link
Collaborator

No description provided.

@AMontagu AMontagu changed the base branch from master to fix/defaultValue January 18, 2024 12:06
@AMontagu AMontagu merged commit 072ca66 into fix/defaultValue Jan 18, 2024
4 checks passed
@AMontagu AMontagu deleted the defaultValue/NotWorkingUpdateDefaultGRPCValue branch January 18, 2024 12:08
@AMontagu AMontagu mentioned this pull request Jan 18, 2024
django_socio_grpc/proto_serializers.py Show resolved Hide resolved
django_socio_grpc/proto_serializers.py Show resolved Hide resolved
django_socio_grpc/proto_serializers.py Show resolved Hide resolved
django_socio_grpc/proto_serializers.py Show resolved Hide resolved
Comment on lines +128 to +129
# elif field.required and field.field_name in message.DESCRIPTOR.fields_by_name:
# data_dict[field.field_name] = message.DESCRIPTOR.fields_by_name[field.field_name].default_value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? but yes to delete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants