fix: GRPCException should inherit from APIException #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMontagu
reviewed
Nov 30, 2023
|
|
||
| def log_exception(self, exception: Exception, message: str, extra={}): | ||
| logging_level = "ERROR" | ||
| if isinstance(exception, GRPCException): |
There was a problem hiding this comment.
this should be issubclass if someone want to override our class to change loggign level no ?
There was a problem hiding this comment.
Exceptions are always instanciated
| status_code, details = self._get_status_code_and_details(exc) | ||
| await context.abort(status_code, details) | ||
|
|
||
| def log_exception(self, exception: Exception, message: str, extra={}): |
There was a problem hiding this comment.
this need doc string and may not have it's place in servicer proxy. Maybe a method in exception.py too
There was a problem hiding this comment.
This is closely tied with the class and can be easily overriden
AMontagu
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.