sync vs async example v1 #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor logging
|
Thank you for the work. It will need informations about the fact that we plan to remove Sync support in V1.0.0 and explation about the risk of using stream in sync mode as it block the all thread while not finished. It would be great to also document all the method that are async ready by DSG (ais_valid, amessage, aget_serializer, ...) I am available if you need more informations from me to do that |
|
You're using the old doc, you have to merge from the |
added 2 commits
December 1, 2023 17:23
AMontagu
reviewed
Dec 1, 2023
| ------------------- | ||
|
|
||
| Since Django 4.1, Django can run ORM queries asynchronously. |
There was a problem hiding this comment.
ORM is stil synchrone. It's the view that can bu run asynchronously
| ------------ | ||
|
|
||
| If you want to use the sync mode, you should know that we will no longer support this mode from version 1.0.0 of Django Socio gRPC. |
There was a problem hiding this comment.
Suggested change
| If you want to use the sync mode, you should know that we will no longer support this mode from version 1.0.0 of Django Socio gRPC. | |
| If you want to use the sync mode, you should know that we are thinking about droping sync support from version 1.0.0 of Django Socio gRPC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.