(#265): async image upload example - fully working #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMontagu
reviewed
Apr 8, 2024
| response_name="UploadStatus", | ||
| request_stream=True, | ||
| ) | ||
| async def UpdateImage(self, request, context): |
There was a problem hiding this comment.
UploadImage may be a better name
| request_name="FileChunk", | ||
| response=[{"name": "success", "type": "bool"}], | ||
| response_name="UploadStatus", | ||
| request_stream=True, |
There was a problem hiding this comment.
why not using a response stream too to send upload progress ?
|
|
||
| queryset = self.get_queryset() | ||
|
|
||
| book = await sync_to_async(queryset.get)(book_id=book_id) |
There was a problem hiding this comment.
book = await queryset.aget(book_id=book_id)
There was a problem hiding this comment.
actually if you use the lookupfield in the request (remplacing book_id by just id) you can directly do something like:
book = await self.aget_object()
| book = await sync_to_async(queryset.get)(book_id=book_id) | ||
|
|
||
| print("----- found:", book.title) | ||
| res = await sync_to_async(book.image.save)(filename, f, save=True) |
There was a problem hiding this comment.
res = await book.image.asave(filename, f, save=True)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @AMontagu and @legau,
after a long search, I finally managed to build a working example of an Image Upload and Update.
The sync_to_async part still looks a little bit clumsy - is there a nicer way to formulate it ?
If not, please merge it into master and correct the documentation.
Merci.