Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bulk item creation example (PR #261) #17

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

markdoerr
Copy link
Collaborator

This is the corresponding bulk creation example to socotecio/django-socio-grpc#261

(s. jupyter/example_bib_explorer.ipynb )

@markdoerr
Copy link
Collaborator Author

@legau and @AMontagu,

interestingly the bulk creation is not much faster (in the range of 1-2 seconds / 1000 Authors).

Does that mean that the main bottleneck is not the serialisation from a dictionary -> protobuf message on the client side, but the gRPC / DRF deserialisation on the server side ?

@AMontagu
Copy link
Collaborator

AMontagu commented Apr 8, 2024

@markdoerr Yes that what it mean.

We will try to work on that but not in the close futur. As we do not accept the AsyncBulkCreateMixins in DSG core. What you plan on this PR ?
Do you wan to change it and merge it or closing it ?

@markdoerr
Copy link
Collaborator Author

Thanks for the reminder @AMontagu ,
if you do not mind, I would make the example nice and if you agree, we could merge it into master.
(I was just waiting to give you some time to analyse the performance issue :)

@AMontagu
Copy link
Collaborator

AMontagu commented Apr 8, 2024

Okay for me to merge it once everything good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants