Skip to content

support 2.3 on CI #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ioquatix merged 2 commits into from
Jul 9, 2019
Merged

support 2.3 on CI #2

ioquatix merged 2 commits into from
Jul 9, 2019

Conversation

@ganmacs
Copy link
Contributor

@ganmacs ganmacs commented Jun 20, 2019

@ganmacs ganmacs mentioned this pull request Jun 20, 2019
Merged
@ioquatix
Copy link
Member

ioquatix commented Jun 20, 2019

Hmm, looks like unpack1 is undefined on 2.3...

The previous way is unpack(...).first.

@ioquatix
Copy link
Member

ioquatix commented Jun 20, 2019

I am happy to go back to unpack(...).first but I start asking myself is it really good idea? It's slower, Ruby 2.3 is EOL, etc. I know for some business it's important.

Maybe simpler option is to have monkey patch for backwards compatibility, e.g. if ruby is 2.3, define unpack1, etc. What do you think?

@ganmacs
Copy link
Contributor Author

ganmacs commented Jun 20, 2019

Maybe simpler option is to have monkey patch for backwards compatibility, e.g. if ruby is 2.3, define unpack1, etc. What do you think?

looks good. I'll do that.

@ganmacs
Copy link
Contributor Author

ganmacs commented Jun 28, 2019

@ioquatix friendly ping

@ioquatix
Copy link
Member

ioquatix commented Jun 28, 2019

Thank you for friendly ping. I will review this weekend.

@ioquatix ioquatix self-assigned this Jun 28, 2019
@ioquatix ioquatix self-requested a review June 28, 2019 05:07
@ganmacs ganmacs mentioned this pull request Jul 3, 2019
Closed
@ioquatix ioquatix merged commit 025fa1c into socketry:master Jul 9, 2019
@ioquatix
Copy link
Member

ioquatix commented Jul 9, 2019

Thanks for your effort here.

@ioquatix ioquatix added this to the 0.9. milestone Jul 9, 2019
@ioquatix ioquatix added the enhancement New feature or request label Jul 9, 2019
@ioquatix
Copy link
Member

ioquatix commented Jul 9, 2019

@ganmacs there are more issues to sort out: socketry/async-http#24

@ganmacs ganmacs deleted the support-2.3 branch July 10, 2019 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ioquatix ioquatix Awaiting requested review from ioquatix

Assignees

@ioquatix ioquatix

Labels

enhancement New feature or request

Projects

None yet

Milestone

0.9.2

Development

Successfully merging this pull request may close these issues.

2 participants

@ganmacs @ioquatix