Use SleepEx instead of Sleep #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sleep is replaced with rb_w32_Sleep by Ruby, which tries to release GVL, though select_poll doesn't have GVL.
| @@ -193,26 +191,6 @@ select_poll (EV_P_ ev_tstamp timeout) | |||
| int res; | |||
| int fd_setsize; | |||
|
|
|||
| #ifdef _WIN32 | |||
There was a problem hiding this comment.
Does using SleepEx care this situation?
There was a problem hiding this comment.
Once I thought NULL fds for select cause stuck, but https://github.com/tarcieri/cool.io/pull/47/files#diff-c9164d22260cba57b9d4a9beb08b42d0L258 says it will return EINVAL. I confirmed it with simple C program.
Now I think I misunderstood stuck on select() instead of stuck on Sleep().
Anyway this code still has a meaning as shortcut (skip select() and just sleep), but I choose code size.
repeatedly
added a commit
that referenced
this pull request
Sep 26, 2015
Use SleepEx instead of Sleep
|
Okay. Just merged. |
nurse
added a commit
to fluent/fluentd
that referenced
this pull request
Sep 28, 2015
nurse
added a commit
to fluent/fluentd
that referenced
this pull request
Sep 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sleep is replaced with rb_w32_Sleep by Ruby,
which tries to release GVL, though select_poll
doesn't have GVL.