Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure timeout_after yields duration. #149

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Ensure timeout_after yields duration. #149

merged 1 commit into from
Feb 18, 2022

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Feb 18, 2022 •
edited
Loading

Description

As discussed in #145

We need to retain backwards compatibility with Async 1 interface with_timeout which is an acceptable middle ground.

Types of Changes

  • Bug fix.
  • Breaking change.

Testing

  • I added tests for my changes.
  • I tested my changes locally.
  • I tested my changes in staging.
  • I tested my changes in production.

olleolleolle
olleolleolle reviewed Feb 18, 2022
View reviewed changes
lib/async/task.rb Outdated Show resolved Hide resolved
@ioquatix ioquatix merged commit b120e65 into main Feb 18, 2022
@ioquatix ioquatix deleted the fix-timeout_after branch February 18, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ioquatix @olleolleolle