Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2-sockets cannot connect to Socket.io 4.3.0 with allowEIO3 enabled. #4120

Closed
spasma opened this issue Oct 14, 2021 · 3 comments
Closed

v2-sockets cannot connect to Socket.io 4.3.0 with allowEIO3 enabled. #4120

spasma opened this issue Oct 14, 2021 · 3 comments
Labels
unable to reproduce We were unable to reproduce the issue

Comments

@spasma
Copy link

spasma commented Oct 14, 2021

Describe the bug
Version 4.3.0 breaks allowEIO3 support. I know the package is not officially released yet, but I accidentally updated tot 4.3.0 due to my package file with socket.io": "^4.2.0".

I saw that allowEIO3 was removed from the EngineOptions-interface in 4.2.0...4.3.0#diff-d5a4b3a0309f2337144861084c1014523cced561eb722cb9684c63f5e41e0567L119, maybe that's related to this issue.

To Reproduce
Connect to a server with a 2.0-client, with allowEIO3 on true while having version 4.3.0 installed.

Expected behavior
I expect to successfully connect to a 4.3.0-server with allowEIO3 on.

@spasma
Copy link
Author

spasma commented Oct 14, 2021

Just saw the reference by @chriskrycho.

It is possibly not only 2.0-clients, I'm moving from 2.0 to 4.* and all clients are currently still on the 2.0-client.

At this point I'm not sure if the 3.0-client was connecting to the 4.3 dev server or the production server on 4.2.

Excuses for the confusion.

darrachequesne added a commit to socketio/socket.io-fiddle that referenced this issue Oct 15, 2021
@darrachequesne
Copy link
Member

Hi! I cannot reproduce: https://github.com/socketio/socket.io-fiddle/tree/issues/socket.io/4120

Could you please check?

The allowEIO3 option is still supported, it was only moved to the engine.io repository: https://github.com/socketio/engine.io/blob/fe5d97fc3d7a26d34bce786a97962fae3d7ce17f/lib/server.ts#L113

@darrachequesne darrachequesne added unable to reproduce We were unable to reproduce the issue and removed bug Something isn't working labels Oct 15, 2021
@spasma
Copy link
Author

spasma commented Oct 15, 2021

Issue #4121 is related, it's not only 2.0-clients.

@spasma spasma closed this as completed Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unable to reproduce We were unable to reproduce the issue
Projects
None yet
Development

No branches or pull requests

2 participants