Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update notepack.io to ~3? #462

Closed
MasterOdin opened this issue Sep 14, 2022 · 1 comment
Closed

Update notepack.io to ~3? #462

MasterOdin opened this issue Sep 14, 2022 · 1 comment

Comments

@MasterOdin
Copy link
Contributor

The @socket.io/redis-emitter library had a recent major update that brought a new major version of the underlying notepack.io library to fix an issue handling BigInt, and so has the patch notes:

Important note! There is a non backward-compatible change regarding Date objects, which means that the adapter may not be able to properly decode them.

Should a similar update to notepack.io happen here so that the emitter and adapter are kept fully compatible?
@MasterOdin MasterOdin mentioned this issue Nov 14, 2022
Merged
darrachequesne pushed a commit that referenced this issue Dec 7, 2022
@MasterOdin @darrachequesne
feat: add option to allow usage of custom parser (#471)
73f6320 
This PR adds a new parser option to the adapter constructor to allow
setting a custom parser to use, defaulting to using notepack.io. This
would allow someone to use a different msgpack library if they wanted,
or even an entirely different protocol altogether (e.g. protobuf).

Related:

- #462
- #469
@darrachequesne
Copy link
Member

Done in c96b2e7, and included in v8.0.0. Thanks for the heads-up 👍

@joeawillis joeawillis mentioned this issue Jul 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MasterOdin @darrachequesne