-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make an es6 version also #1378
Comments
Sounds reasonable. Let's add this 👍 |
Although bundling(webpack, browsify,...) would be still a good but legacy approach, a native ES6 module supporting would be needed also. I voted to this. |
Angular CLI even throws a warning:
|
See also: socketio/engine.io-client@00d7e7d Related: - #1188 - #1378
This was implemented in 16b6569, included in |
Note: for support questions, please use one of these channels: stackoverflow or slack
For bug reports and feature requests for the Swift client, please open an issue there.
For bug reports and feature requests for the Java client, please open an issue there.
You want to:
Current behaviour
What is actually happening?
I can see that this is a commonjs module, webpack supports interoptability across modules, but isnt recommended.
Steps to reproduce (if the current behaviour is a bug)
Note: the best way (and by that we mean the only way) to get a quick answer is to provide a failing test case by forking the following fiddle.
Expected behaviour
What is expected?
There should be es6 exports instead of module.exports for use in the browser, due to the fact socket.io-client is a client side portion of socket.io.
Setup
Other information (e.g. stacktraces, related issues, suggestions how to fix)
The text was updated successfully, but these errors were encountered: