fix: remove polyfill for process in the bundle

A polyfill for Node.js "process" was included in the final bundle. Reference: https://webpack.js.org/configuration/node/
socketio · Feb 2, 2021 · 61afc5d · 61afc5d
1 parent 47f917a
commit 61afc5d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/support/webpack.config.js b/support/webpack.config.js
@@ -14,9 +14,7 @@ module.exports = {
   },
   mode: "development",
   devtool: "source-map",
-  node: {
-    Buffer: false,
-  },
+  node: false,
   module: {
     rules: [
       {

diff --git a/test/index.js b/test/index.js
@@ -1,8 +1,8 @@
-require("./support/env");
+const { browser } = require("./support/env");
 
 // whitelist some globals to avoid warnings
-if (global.mocha) {
-  global.mocha.globals(["___eio", "eio_iframe_*"]);
+if (browser) {
+  window.mocha.globals(["___eio", "eio_iframe_*"]);
 }
 
 require("./url.ts");

diff --git a/test/support/env.js b/test/support/env.js
@@ -2,10 +2,10 @@
 // we only do this in our tests because we need to test engine.io-client
 // support in browsers and in node.js
 // some tests do not yet work in both
-exports.browser = !!global.window;
+exports.browser = typeof window !== "undefined";
 exports.node = !exports.browser;
 
-if (!global.location) {
+if (exports.node) {
   global.location = {
     protocol: "http:",
     host: "localhost:3210",