Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift4.2 #1101

Closed
lixiang1994 opened this issue Oct 8, 2018 · 2 comments
Closed

Swift4.2 #1101

lixiang1994 opened this issue Oct 8, 2018 · 2 comments

Comments

@lixiang1994
Copy link

And .podspec Add s.swift_version = "4.2" , Please

@wzio
Copy link

wzio commented Oct 31, 2018

1 should remove .swift-version file
2 in Socket.IO-Client-Swift.podspec file should remove s.pod_target_xcconfig = { 'SWIFT_VERSION' => '4.0' }, and add s.swift_version = '4.2'

@wzio
Copy link

wzio commented Oct 31, 2018

for the user, an other solution: add code in your podfile

post_install do |installer|
  installer.pods_project.targets.each do |target|
      if ['socket.io-client-swift'].include? target.name
          target.build_configurations.each do |config|
              config.build_settings['SWIFT_VERSION'] = '4.2'
          end
      end
  end
end

DmitryPR pushed a commit to DmitryPR/socket.io-client-swift that referenced this issue Nov 28, 2018
Remove the swift version and update podspec to include Swift 4.2

Fixes socketio#1101
DmitryPR pushed a commit to DmitryPR/socket.io-client-swift that referenced this issue Nov 28, 2018
This solves the issue:
socketio#1101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants