Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve compat with ts in node16/bundler mode #689

Merged
merged 1 commit into from
Aug 17, 2023
Merged

fix: improve compat with ts in node16/bundler mode #689

merged 1 commit into from
Aug 17, 2023

Commits on Aug 14, 2023

  1. fix: improve compat with ts in node16/bundler mode 

    when using the newer resolution and module modes of typescript, it could pick up `./wrapper.mjs`, which does not have a `.d.ts` file next to it.

added the `"types"` condition to ensure imports to `"engine.io"` always get a type, no matter if they are sourced in commonjs or esm.
    @AviVahl
    AviVahl committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    b8e5696 View commit details
    Browse the repository at this point in the history