Cookie Improvements #423
Closed
Cookie Improvements #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlimkin
commented
Sep 26, 2016
dlimkin
commented
- fix cookiePath empty bug;
- remove unused readFileSync require;
- add dependence cookie module;
- Set-Cookie refactor with cookie module;
- add options cookieHttpOnly;
|
+1 for the |
|
@dlimkin could you please fix the conflicts and document the |
added 7 commits
October 31, 2016 14:13
add dependence cookie module; Set-Cookie refactor with cookie module;
fix cookie tests;
cookiePath option default set to '/'; cookieHttpOnly option default set to true; add documentation for the cookieHttpOnly option;
update code style by ESLint;
|
Done!
|
darrachequesne
pushed a commit
that referenced
this pull request
Nov 3, 2016
darrachequesne
pushed a commit
that referenced
this pull request
May 8, 2020
Revert "package: bump `zuul-ngrok`"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.