Support VIRTIO_RING_F_EVENT_IDX #68
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| vq->last_used_idx++; | ||
|
|
||
| if (cbe.cb) { | ||
| cbe.cb(cbe.opaque, used_len); | ||
| } | ||
| } | ||
| } | ||
| if (vq->event_idx_enabled) { | ||
| *vq->used_event = sys_cpu_to_le16(vq->last_used_idx); | ||
| barrier_dmem_fence_full(); |
There was a problem hiding this comment.
The new event-idx handling in virtio_isr() writes to used_event and then calls barrier_dmem_fence_full() (lines 62‑64), but drivers/virtio/virtio_common.c still only includes logging, byteorder, and virtio headers (lines 7‑11). None of those headers declare barrier_dmem_fence_full(), so this translation unit now lacks a prototype for that function and fails to compile with implicit declaration of function ‘barrier_dmem_fence_full’ when built with the default C standard. Please add #include <zephyr/sys/barrier.h> to this file’s include list.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task