feat: support for maven wrapper (mvnw) #50
Conversation
sfat
force-pushed
the
feat/support-mvn-wrapper
branch
4 times, most recently
from
f24662d to
38a4b9a
Compare
sfat
force-pushed
the
feat/support-mvn-wrapper
branch
from
38a4b9a to
699df0e
Compare
| // When we have `mvn`, we can run the subProcess from anywhere. | ||
| // However due to https://github.com/takari/maven-wrapper/issues/133, `mvnw` can only be run | ||
| // within the directory where `mvnw` exists | ||
| function calculateTargetFilePath(mavenCommand, root: string, targetPath) { |
There was a problem hiding this comment.
isn't this what cwd is for?
There was a problem hiding this comment.
yes, it is, but the problem occurs when you specify a relative path to the targetFile will encounter a error as the mvnw is found, but the pom.xml is not present in that directory.
So, until that is fixed, you will not be able to specify a relative path for the targeFile (../somewhere-else) when mvnw is present.
That's what I meant by limitation.
Because at first I just went ahead and cwd with where the targetFile path is, but then I bumped into issues where the path to the pom.xml would be messed up while subProcess would be ran in both mvn and mvnw cases.
There was a problem hiding this comment.
In that case let's add a check to see that mvnw is present in the root and propagate an error with instructions on how to properly run if that is not the case.
There was a problem hiding this comment.
will that work if you go with the targetFile approach being outside of that directory where you want to test your project?
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What does this PR do?
implementation for https://github.com/snyk/snyk/issues/957