fix: add helper to read test fixtures #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
gitphill
force-pushed
the
fix/add-test-helper-to-read-fixtures
branch
2 times, most recently
from
ad79b76 to
84816be
Compare
orsagie
reviewed
Nov 21, 2019
| { | ||
| "plugin": { "name": "bundled:maven", "runtime": "unknown" }, | ||
| "package": { | ||
| "name": "fixtures.jars:spring-core-5.1.8.RELEASE.jar", |
There was a problem hiding this comment.
Can you rename this file to match the jar (or rename the jar to match the file) so it's easier to see what expected goes with what fixture?
Added file-helper to read test fixtures. Moved fixtures into their own folder. Added expected JSON to test inspect results fully. Updated eslint versions to remove npm install warnings.
gitphill
force-pushed
the
fix/add-test-helper-to-read-fixtures
branch
from
84816be to
79c3d85
Compare
|
🎉 This PR is included in version 2.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added file-helper to read test fixtures.
Moved fixtures into their own folder.
Added expected JSON to test inspect results fully.
Updated eslint versions to remove npm install warnings.