fix: support gradle 2 and newer #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyegupov
force-pushed
the
fix/support-gradle-2-and-newer
branch
3 times, most recently
from
14174d6 to
40aaf27
Compare
kyegupov
force-pushed
the
fix/support-gradle-2-and-newer
branch
4 times, most recently
from
960514b to
0a2e662
Compare
kyegupov
changed the title
miiila
approved these changes
Jun 7, 2019
kyegupov
force-pushed
the
fix/support-gradle-2-and-newer
branch
2 times, most recently
from
aebe852 to
89ff656
Compare
kyegupov
force-pushed
the
fix/support-gradle-2-and-newer
branch
from
89ff656 to
7cb06dd
Compare
|
🎉 This PR is included in version 2.12.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves the issue with Gradle 2 (which does not support configuration attributes), adapts test to conform to both Gradle 2 and 3-5 resolution rules.
This fixes the issue that caused the rollback snyk/cli#563
Where should the reviewer start?
init.grade is where the logic is