fix: change signature and pull node and python data #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nozik
reviewed
Jan 23, 2025
prsnca
force-pushed
the
expand-image-content-extraction
branch
2 times, most recently
from
e57363a to
6675ced
Compare
nozik
reviewed
Jan 23, 2025
| (fact) => fact.type === "applicationFiles", | ||
| )!.data; | ||
|
|
||
| const fileList = applicationFilesFact.data[0].fileHierarchy.map((fh) => fh.path); |
There was a problem hiding this comment.
Why map if you're only counting?
There was a problem hiding this comment.
this is the model:
export interface ApplicationFileInfo {
path: string;
}
export interface ApplicationFiles {
fileHierarchy: ApplicationFileInfo[];
moduleName?: string;
language: string;
}
so in order to pull out the list of files - i have to extract each path by its own...
prsnca
force-pushed
the
expand-image-content-extraction
branch
4 times, most recently
from
50d53ab to
dd290d0
Compare
nozik
reviewed
Jan 23, 2025
prsnca
force-pushed
the
expand-image-content-extraction
branch
from
dd290d0 to
eb2750b
Compare
nozik
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.