fix: redhat-content-manifests content sets parsing UNIFY-387 #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrobuta
force-pushed
the
fix/redhat-content-manifests-content-lists-parsing
branch
from
2b9af91 to
6c95111
Compare
neil-snyk
approved these changes
Nov 15, 2024
adrobuta
force-pushed
the
fix/redhat-content-manifests-content-lists-parsing
branch
from
6c95111 to
844fa40
Compare
adrobuta
deleted the
fix/redhat-content-manifests-content-lists-parsing
branch
|
🎉 This PR is included in version 6.13.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When content_sets is not present is absent from the redhat-content-manifests we try to cast to string [] an undefined value.
https://app.datadoghq.com/logs?query=%22cli%20analytics%22%20%40polaris.instance%3Apolaris-prod-mt-gcp-1%20%2A%3Aintermediate%2A&agg_m=count&agg_m_source=base&agg_q=%40originalError.message&agg_q_source=base&agg_t=count&cols=host%2Cservice%2C%40originalError.message%2C%40name%2C%40data&fromUser=true&messageDisplay=inline&refresh_mode=sliding&storage=hot&stream_sort=desc&top_n=30&top_o=top&viz=toplist&x_missing=true&from_ts=1730318170926&to_ts=1731614170926&live=true
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Screenshots
Additional questions