Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: python dist-packages support #476

Merged
merged 1 commit into from
Jan 10, 2023
Merged

fix: python dist-packages support #476

merged 1 commit into from
Jan 10, 2023

Conversation

ahmed-agabani-snyk
Copy link
Contributor

@ahmed-agabani-snyk ahmed-agabani-snyk commented Jan 10, 2023 •
edited
Loading

What does this PR do?

  • adds support for python dist-packages

Any background context you want to provide?

What are the relevant tickets?

  • ZEN-39783

Screenshots

pip-dist-packages.tar contents:

find . -name METADATA
./usr/local/lib/python3.10/dist-packages/rpc.py-0.4.2.dist-info/METADATA
./usr/local/lib/python3.10/dist-packages/Jinja2-3.1.2.dist-info/METADATA
./usr/local/lib/python3.10/dist-packages/six-1.16.0.dist-info/METADATA
./usr/local/lib/python3.10/dist-packages/setuptools-63.2.0.dist-info/METADATA
./usr/local/lib/python3.10/dist-packages/Werkzeug-2.2.2.dist-info/METADATA
./usr/local/lib/python3.10/dist-packages/click-8.1.3.dist-info/METADATA
./usr/local/lib/python3.10/dist-packages/MarkupSafe-2.1.1.dist-info/METADATA
./usr/local/lib/python3.10/dist-packages/wheel-0.37.1.dist-info/METADATA
./usr/local/lib/python3.10/dist-packages/pip-22.2.1.dist-info/METADATA
./usr/local/lib/python3.10/dist-packages/itsdangerous-2.1.2.dist-info/METADATA
./usr/local/lib/python3.10/dist-packages/Flask-2.2.2.dist-info/METADATA

@ahmed-agabani-snyk ahmed-agabani-snyk self-assigned this Jan 10, 2023
@github-actions
Copy link

github-actions bot commented Jan 10, 2023 •
edited by ahmed-agabani-snyk
Loading

Expected release notes (by @ahmed-agabani-snyk)

fixes:
python dist-packages support (259de20)

others (will not be included in Semantic-Release notes):
pin semantic release (96e6544)
adjust codeowners to new team name (c08202c)
fix alerting channels (993181b)
use slack orb to notify (1957ac4)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@ahmed-agabani-snyk ahmed-agabani-snyk marked this pull request as ready for review January 10, 2023 13:15
@ahmed-agabani-snyk ahmed-agabani-snyk requested a review from a team as a code owner January 10, 2023 13:15
pecodez
pecodez approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@pecodez pecodez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahmed-agabani-snyk ahmed-agabani-snyk merged commit 8ff565c into main Jan 10, 2023
@ahmed-agabani-snyk ahmed-agabani-snyk deleted the fix/python-dist-packages-support branch January 10, 2023 13:22
@snyk-deployer
Copy link
Collaborator

🎉 This PR is included in version 5.7.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Jan 10, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pecodez pecodez pecodez approved these changes

Assignees

@ahmed-agabani-snyk ahmed-agabani-snyk

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmed-agabani-snyk @snyk-deployer @pecodez