Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ecosystems validate external references urls #97

Merged
merged 2 commits into from
Jan 6, 2025
Merged

fix: ecosystems validate external references urls #97

merged 2 commits into from
Jan 6, 2025
+7 −3

Conversation

acidghost
Copy link
Contributor

Fixes #96.

@acidghost acidghost requested review from garethr and a team as code owners January 6, 2025 10:10
mcombuechen
mcombuechen reviewed Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@mcombuechen mcombuechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @acidghost 🙏

I think the approach looks good. Just one tiny nit 😄

lib/ecosystems/enrich_cyclonedx.go Outdated Show resolved Hide resolved
@acidghost acidghost requested a review from mcombuechen January 6, 2025 11:32
@mcombuechen mcombuechen merged commit 7d69dae into snyk:main Jan 6, 2025
3 checks passed
@acidghost acidghost deleted the fix/invalid-ecosystems-urls branch January 8, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcombuechen mcombuechen mcombuechen approved these changes

@garethr garethr Awaiting requested review from garethr garethr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ecosyste.ms returns invalid URL for package homepage
2 participants
@acidghost @mcombuechen