Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: linting #23

Merged
merged 2 commits into from
Jun 14, 2023
Merged

chore: linting #23

merged 2 commits into from
Jun 14, 2023

Conversation

mcombuechen
Copy link
Collaborator

One thing I missed when working with the code was a stricter check for error handling. This motivated me to open this PR.

  • configures errcheck to require handling of errors
  • adds linters mispell, goimports
  • fixes formatting issues
  • introduces a global linter config yaml

@mcombuechen mcombuechen requested a review from garethr as a code owner June 14, 2023 13:19
garethr
garethr approved these changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@garethr garethr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@garethr garethr merged commit 7ceeeb8 into snyk:main Jun 14, 2023
@mcombuechen mcombuechen deleted the chore/format-lint branch June 15, 2023 10:14
garethr pushed a commit that referenced this pull request Aug 18, 2023
@mcombuechen @garethr
chore: linting (#23)
3a8e141 
* chore: add golangci-lint config

* refactor: enable linters and adapt code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethr garethr garethr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcombuechen @garethr