Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getSnykOrg does not error on non-200 responses #48

Closed
mcombuechen opened this issue Oct 31, 2023 · 0 comments · Fixed by #50
Closed

getSnykOrg does not error on non-200 responses #48

mcombuechen opened this issue Oct 31, 2023 · 0 comments · Fixed by #50
Labels
bug Something isn't working

Comments

@mcombuechen
Copy link
Collaborator

When looking up user info to infer a user’s org ID, the getSnykOrg function will happily carry on even after non-200 OK responses (e.g. for bad API tokens), resulting in a nil UUID, resulting in a runtime panic.
@mcombuechen mcombuechen added the bug Something isn't working label Oct 31, 2023
mcombuechen added a commit to mcombuechen/parlay that referenced this issue Oct 31, 2023
@mcombuechen
fix: return error during failed userinfo lookup
e9fe694 
Closes snyk#48.
@mcombuechen mcombuechen mentioned this issue Oct 31, 2023
Merged
@mcombuechen mcombuechen linked a pull request Oct 31, 2023 that will close this issue
fix: user info #50
Merged
mcombuechen added a commit to mcombuechen/parlay that referenced this issue Feb 5, 2024
@mcombuechen
fix: return error during failed userinfo lookup
bc887c3 
Closes snyk#48.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: user info mcombuechen/parlay
1 participant
@mcombuechen