Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use latest python plugin #984

Merged
merged 1 commit into from
Jan 31, 2020
Merged

feat: use latest python plugin #984

merged 1 commit into from
Jan 31, 2020

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jan 30, 2020 •
edited
Loading

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

  • it dropped some update deps logic which is not used in CLI
  • no functional change for cli

@lili2311 lili2311 requested a review from a team as a code owner January 30, 2020 09:49
@lili2311 lili2311 self-assigned this Jan 30, 2020
@ghost ghost requested review from dkontorovskyy and orsagie January 30, 2020 09:49
dkontorovskyy
dkontorovskyy approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@dkontorovskyy dkontorovskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lili2311
feat: use latest python plugin
3c06cb6 
- removes remediation logic from plugin
- no functional change for cli
@lili2311 lili2311 force-pushed the feat/bump-python-plugin branch from a54b401 to 3c06cb6 Compare January 31, 2020 09:57
@lili2311 lili2311 merged commit 2c21f03 into master Jan 31, 2020
@lili2311 lili2311 deleted the feat/bump-python-plugin branch January 31, 2020 11:46
@snyksec
Copy link

snyksec commented Jan 31, 2020

🎉 This PR is included in version 1.290.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@logangeorgebrown logangeorgebrown mentioned this pull request Jun 21, 2023
Closed
@AliADDOU AliADDOU mentioned this pull request Jun 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkontorovskyy dkontorovskyy dkontorovskyy approved these changes

@orsagie orsagie Awaiting requested review from orsagie

Assignees

@lili2311 lili2311

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lili2311 @snyksec @dkontorovskyy