Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move --json for docker cli right after the command #980

Merged
merged 1 commit into from
Jan 28, 2020
Merged

fix: move --json for docker cli right after the command #980

merged 1 commit into from
Jan 28, 2020

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jan 28, 2020 •
edited
Loading

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Move the --json param to directly after the snyk command in case some arguments are being passed down to the language plugin like maven / gradle directly

@lili2311 lili2311 requested a review from a team as a code owner January 28, 2020 10:12
@lili2311 lili2311 self-assigned this Jan 28, 2020
@ghost ghost requested review from dkontorovskyy and orsagie January 28, 2020 10:12
@gitphill gitphill merged commit d282b35 into master Jan 28, 2020
@gitphill gitphill deleted the fix/move-docker-json-before-lang-args branch January 28, 2020 11:19
@snyksec
Copy link

snyksec commented Jan 28, 2020

🎉 This PR is included in version 1.284.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitphill gitphill gitphill approved these changes

@dkontorovskyy dkontorovskyy Awaiting requested review from dkontorovskyy

@orsagie orsagie Awaiting requested review from orsagie

Assignees

@lili2311 lili2311

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lili2311 @snyksec @gitphill