Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snyk --version #971

Merged
merged 2 commits into from
Jan 27, 2020
Merged

fix: snyk --version #971

merged 2 commits into from
Jan 27, 2020

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jan 24, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Fix the snyk --version hotload import, which was broken during refactor
https://github.com/snyk/snyk/issues/969

@lili2311 lili2311 requested a review from a team as a code owner January 24, 2020 11:02
@ghost ghost requested review from aviadhahami and gitphill January 24, 2020 11:02
@lili2311 lili2311 force-pushed the fix/snyk-version branch 2 times, most recently from 5d6ef63 to 6708cfd Compare January 24, 2020 11:31
@lili2311 lili2311 self-assigned this Jan 24, 2020
@lili2311 lili2311 removed the request for review from aviadhahami January 24, 2020 11:59
Fix typescript issues causing version to no longer work.
Fix issue running snyk --version on windows with dirty files.
@gitphill
Copy link
Contributor

not sure why this is still failing in AppVeyor - test pass in test Windows VM.

@lili2311 lili2311 force-pushed the fix/snyk-version branch 2 times, most recently from 7f7db8e to ea483ec Compare January 27, 2020 10:14
Specific Windows test is needed
@lili2311 lili2311 merged commit 88b7a15 into master Jan 27, 2020
@lili2311 lili2311 deleted the fix/snyk-version branch January 27, 2020 12:11
@snyksec
Copy link

snyksec commented Jan 27, 2020

🎉 This PR is included in version 1.281.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants