feat: increase default levels deep to 2 for --all-projects
#970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
lili2311
force-pushed
the
feat/increase-default-depth-all-projects
branch
from
b470cab to
b1c0822
Compare
lili2311
commented
Jan 24, 2020
| @@ -24,7 +24,7 @@ export async function getDepsFromPlugin( | |||
| let inspectRes: pluginApi.InspectResult; | |||
|
|
|||
| if (options.allProjects) { | |||
| const levelsDeep = options.detectionDepth || 1; // default to 1 level deep | |||
| const levelsDeep = options.detectionDepth; | |||
There was a problem hiding this comment.
default defined inside find function is 2
There was a problem hiding this comment.
I can predict the future!
goes to buy lottery ticket
gitphill
approved these changes
Jan 24, 2020
|
we could update help text with new default depth |
gitphill
force-pushed
the
feat/increase-default-depth-all-projects
branch
from
b1c0822 to
a666a6c
Compare
For `--all-projects` arg only. Two was selected based on usage seen so far. Updated help text with new default.
gitphill
force-pushed
the
feat/increase-default-depth-all-projects
branch
from
a666a6c to
7c60f77
Compare
|
🎉 This PR is included in version 1.281.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable the default detection depths to increase from 1 to 2 folders deep.