fix: increase cli test timeout #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lili2311
approved these changes
Jan 8, 2020
gitphill
force-pushed
the
fix/increase-cli-test-timeout
branch
3 times, most recently
from
fd20149 to
f739336
Compare
darscan
reviewed
Jan 8, 2020
package.json
Outdated
| @@ -29,7 +29,7 @@ | |||
| "prepare": "npm run build", | |||
| "test:common": "npm run check-tests && npm run build && npm run lint && node --require ts-node/register src/cli test --org=snyk", | |||
| "test:acceptance": "tap test/acceptance/**/*.test.* -Rspec --timeout=300 --node-arg=-r --node-arg=ts-node/register", | |||
| "test:system": "tap test/system/*.test.* -Rspec --timeout=300 --node-arg=-r --node-arg=ts-node/register", | |||
| "test:system": "tap test/system/*.test.* -Rspec --node-arg=-r --node-arg=ts-node/register", | |||
There was a problem hiding this comment.
pretty sure leaving this out means a default timeout of 60 seconds
There was a problem hiding this comment.
i've tried all sorts (up to 600ms), starting to think timeout is not the issue
gitphill
force-pushed
the
fix/increase-cli-test-timeout
branch
from
d888822 to
85e11a2
Compare
ghost
requested review from
gitphill
force-pushed
the
fix/increase-cli-test-timeout
branch
from
ecd5d5e to
8b669a3
Compare
Open authenticate window immediately.
gitphill
force-pushed
the
fix/increase-cli-test-timeout
branch
from
e7230ec to
c6f0b28
Compare
|
OK after lots of experimentation, the real issue was the amount of time we take to open the browser window. Reduced this from 2 seconds to immediate. Allows tests to more consistently pass and not timeout. The timeout was cause because the test teardown brought down the local server before all async tests had returned. |
|
🎉 This PR is included in version 1.277.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jul 16, 2020
This was referenced Aug 4, 2021
This was referenced Aug 5, 2021
This was referenced Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Increase tap timeout from 300 to 400 due to increased test count we're
regularly hitting this timeout.
How should this be manually tested?
npm test:acceptance