chore: refactor auth to async await #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lili2311
force-pushed
the
chore/refactor-auth-to-async-await
branch
4 times, most recently
from
85a8662 to
819d46e
Compare
lili2311
force-pushed
the
chore/refactor-auth-to-async-await
branch
from
819d46e to
11b51f1
Compare
kyegupov
approved these changes
Jun 3, 2019
|
|
||
| return spinner(lbl).then(() => { | ||
| try { |
There was a problem hiding this comment.
you are dropping spinner here? Why?
There was a problem hiding this comment.
Two reasons:
- it prints
Waiting...and then is clears it a few seconds later. Seems not very helpful - the way previous code was written means it cleared the spinner after getting the value back, i a promise chain couldn't see a nice way to add this into the refactored code as we return the value.
There was a problem hiding this comment.
you could return "testAuthComplete().then(spinner.clear)"
But if you feel that the spinner was useless, LET IT DIE.
| const apiUrl = url.parse(config.API); | ||
| const authUrl = apiUrl.protocol + '//' + apiUrl.host; | ||
| const debug = Debug('snyk-auth'); | ||
| let attemptsLeft = 0; | ||
|
|
||
| module.exports = auth; | ||
|
|
||
| function resetAttempts() { | ||
| attemptsLeft = 30; |
There was a problem hiding this comment.
30 is a lot. Do you know how was this number chosen?
There was a problem hiding this comment.
I don't perhaps worth asking in slack, it does seem like a lot
kyegupov
approved these changes
Jun 3, 2019
|
|
||
| return spinner(lbl).then(() => { | ||
| try { |
There was a problem hiding this comment.
you could return "testAuthComplete().then(spinner.clear)"
But if you feel that the spinner was useless, LET IT DIE.
|
🎉 This PR is included in version 1.172.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jun 20, 2023
This was referenced Jun 20, 2023
This was referenced Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
async/awaitinstead of promisesWhere should the reviewer start?
auth/index.tsHow should this be manually tested?
npm run build& then test out usingsnyk auth