feat: Release improved project naming for csproj behind a flag #456
Conversation
|
@lili2311 do we want to refer to this shiny new flag in the help text? |
lili2311
force-pushed
the
feat/optional-proj-names-nuget
branch
2 times, most recently
from
f37c0af to
27ceaa7
Compare
help/help.txt
Outdated
| @@ -56,6 +56,9 @@ Options: | |||
| test a specific sub-project. | |||
| --all-sub-projects For "multi project" configurations, test all | |||
| sub-projects. | |||
| --assets-project-name | |||
| For Nuget projects, forces us to try using the project name | |||
| from the project.assets.json file when possible. | |||
There was a problem hiding this comment.
For Nuget project, forces us to try using the project name from the project.assets.json file when possible.
While very accurate and true, I'm still left a bit puzzled - what happens when I don't use this option? Also, the use of forces us is a bit off to me :)
Suggestion:
When monitoring a .NET project, use the project.assets.json name, if found.
There was a problem hiding this comment.
We might want to specify .NET project using NuGet PackageReference project style.
If you scan a .NET framework that use packages.config insteand of PackageReference, the argument will have no effects.
Also, we could specify that we check for the projectname in project.assets.json or something like that. "Use the project.assets.json project name" might be more accurate
There was a problem hiding this comment.
Can we actually move this documentation to the plugin?
We have many options that are plugin specific, and that is where they should live until we decide otherwise.
lili2311
force-pushed
the
feat/optional-proj-names-nuget
branch
from
27ceaa7 to
49ad843
Compare
| -h, --help ......... This help information. | ||
| -v, --version ...... The CLI version. | ||
|
|
||
| Gradle options: | ||
| --gradle-sub-project=<string> | ||
| For Gradle "multi project" configurations, | ||
| test a specific sub-project. | ||
| --all-sub-projects For "multi project" configurations, test all |
There was a problem hiding this comment.
this one is CLI-wide. but only gradle uses it at the moment. It's fine here now, but we should remember to move it when we support other PM's like yarn workspaces etc.
|
🎉 This PR is included in version 1.154.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
See [snyk-docker-plugin #456](snyk/snyk-docker-plugin#456) for more info.
What does this PR do?
Bump the nuget plugin to release improved naming behind the flag
--assets-project-namesnyk monitor --file=pathtosln --org=snykorg --assets-project-namesnyk/snyk-nuget-plugin#50