Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix html report generation and write monitor json result #164

Closed
wants to merge 3 commits into from
Closed

Fix html report generation and write monitor json result #164

wants to merge 3 commits into from

Conversation

julienduchesne
Copy link
Contributor

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

  • Fixes the HTML report feature. Currently, the output file is text not json but jq is run on it. It returns parse error: Invalid numeric literal at line 2, column 8 Failed to run the process ...
  • Adds a snyk-monitor-result.json

@adrukh
Copy link
Contributor

adrukh commented Jul 17, 2018

@julienduchesne this is indeed an important fix, but it highlights a shortcoming in our docker image entrypoint. We aimed at allowing monitor to run after test via the MONITOR env var, and broke the flow where a user just wants to run snyk monitor via the docker image.

Your suggestion addresses this issue, but I wonder whether it breaks the ability to run snyk test via the docker image, expecting human-readable and not JSON output...

@julienduchesne
Copy link
Contributor Author

We would have to run snyk test twice to get both the json result and the human readable output. Would that be acceptable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants