-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:improve iac test json output #1309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rontalx
force-pushed
the
feat/improve-iac-test-json-output
branch
7 times, most recently
from
August 5, 2020 13:36
ff2d55d
to
7f8f627
Compare
rontalx
force-pushed
the
feat/improve-iac-test-json-output
branch
9 times, most recently
from
August 5, 2020 19:02
e424189
to
b8965f2
Compare
orkamara
reviewed
Aug 6, 2020
orkamara
reviewed
Aug 6, 2020
test/acceptance/workspaces/iac-kubernetes/test-iac-high-result.json
Outdated
Show resolved
Hide resolved
test/acceptance/workspaces/iac-kubernetes/test-iac-low-result.json
Outdated
Show resolved
Hide resolved
test/acceptance/workspaces/iac-kubernetes/test-iac-medium-result.json
Outdated
Show resolved
Hide resolved
rontalx
force-pushed
the
feat/improve-iac-test-json-output
branch
4 times, most recently
from
August 6, 2020 12:27
dc562c9
to
9bfe806
Compare
This was referenced May 13, 2022
This was referenced May 14, 2022
This was referenced May 14, 2022
This was referenced May 14, 2022
This was referenced Sep 23, 2022
This was referenced Sep 24, 2022
This was referenced Sep 25, 2022
This was referenced Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Formats and improves the response we get from Registry's
iac-test
for use in our JSON output.Main changes:
cloudConfigResults
->infrastructureAsCodeIssues
cloudConfigPath
->path
from
,name
iac test
and clean them up.old structure
new structure
Note
There's a refactor I did for the test structure.
there's more to do, but for the sake of releasing this PR I'm pushing it to a separate task.
How should this be manually tested?
Running the
iac-test
flows both with and without the--json
flag.Any background context you want to provide?
Slack Discussion: https://snyk.slack.com/archives/CMM9V3XPY/p1596616315051300
What are the relevant tickets?
Jira Ticket: https://snyksec.atlassian.net/browse/CC-257