-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docker error on monitoring multiple projects #1100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitphill
approved these changes
May 1, 2020
🎉 This PR is included in version 1.316.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced May 23, 2022
This was referenced Sep 25, 2022
This was referenced Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an error thrown by
jq
when using our Docker images to monitor multiple projects (i.e. using--all-projects
.The error thrown by jq is:
How should this be manually tested?
cd docker && docker build -f Dockerfile.docker . -t snyk/snyk-cli:local
docker run --rm -e 'SNYK_TOKEN=***-**-**' -e 'MONITOR=true' -v <full-path-to-repo>:/project snyk/snyk-cli:local test -d
docker run --rm -e 'SNYK_TOKEN=***-**-**' -e 'MONITOR=true' -v <full-path-to-repo>:/project snyk/snyk-cli:local test --all-projects '--detection-depth=3' -d
Any background context you want to provide?
This error occurs because the following line expects the results JSON to be an object with
uri
key, but in the case of multiple projects it's an array of objects withuri
keys:https://github.com/snyk/snyk/blob/d282b35e62874350f818a0bd6726e5994c3be700/docker/docker-entrypoint.sh#L106
Screenshots