Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: typescriptify prompts tests #1026

Merged
merged 3 commits into from
Feb 26, 2020
Merged

chore: typescriptify prompts tests #1026

merged 3 commits into from
Feb 26, 2020

Conversation

dkontorovskyy
Copy link
Contributor

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Typescriptify prompts tests

@dkontorovskyy dkontorovskyy requested a review from a team as a code owner February 26, 2020 08:09
@dkontorovskyy dkontorovskyy self-assigned this Feb 26, 2020
@snyksec
Copy link

snyksec commented Feb 26, 2020 •
edited
Loading

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 1b38af7

gitphill
gitphill reviewed Feb 26, 2020
View reviewed changes
test/prompt-instrument.test.ts Outdated
);

try {
await interactive(vulns, responses, { earlyExit: true });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert something here?

@dkontorovskyy dkontorovskyy force-pushed the chore/typescriptify-prompts-tests branch from e3ad3a0 to 1b38af7 Compare February 26, 2020 10:14
@dkontorovskyy dkontorovskyy merged commit bc8001c into master Feb 26, 2020
@dkontorovskyy dkontorovskyy deleted the chore/typescriptify-prompts-tests branch February 26, 2020 11:29
@claireksnyk claireksnyk mentioned this pull request Jan 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsagie orsagie orsagie approved these changes

@gitphill gitphill gitphill approved these changes

Assignees

@dkontorovskyy dkontorovskyy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkontorovskyy @snyksec @gitphill @orsagie