Merge pull request #2338 from snyk/chore/add-node-loader

chore: add node-loader
snyk · Nov 12, 2021 · 38d4008 · 38d4008
2 parents b826c53 + 15a004b
commit 38d4008
Show file tree

Hide file tree

Showing 4 changed files with 83 additions and 4 deletions.
diff --git a/check-dependencies.config.ts b/check-dependencies.config.ts
@@ -8,6 +8,7 @@ export const config: Options = {
     'tap-junit', // used in circleci
     'lerna', // used in circleci
     'ts-loader', // used by webpack
+    'node-loader', // used by webpack
     'webpack-cli', // used in package.json scripts
     'pkg', // used for binary builds
   ],

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -169,6 +169,7 @@
     "lodash": "^4.17.20",
     "mock-fs": "^4.13.0",
     "nock": "^10.0.6",
+    "node-loader": "^2.0.0",
     "npm-run-all": "^4.1.5",
     "pkg": "^5.3.2",
     "prettier": "^1.18.2",

diff --git a/webpack.common.js b/webpack.common.js
@@ -63,10 +63,8 @@ module.exports = {
         exclude: ['/node_modules'],
       },
       {
-        // `./node_modules/ssh2/lib/protocol/crypto/build/Release/sshcrypto.node` is a binary file introduced
-        // by snyk-docker-plugin -> docker-modem@3
-        test: /ssh2\/lib\/protocol\/crypto\/build\/Release\/sshcrypto\.node/i,
-        type: 'asset/resource',
+        test: /\.node$/,
+        loader: 'node-loader',
       },
     ],
   },