Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: cli arguments support and CJS to ESM conversion #14

Merged
merged 3 commits into from
Jul 12, 2021

Conversation

lirantal
Copy link
Member

@lirantal lirantal commented Jul 12, 2021

Description

Adding support to CLI arguments so we can pass in several options, like:

  • debug
  • project directory path
  • private packages list

However... as things go... this also converts the project from CommonJS to ESM due to some dependency constraints.
I probably could've gone without the meow dependency but, oh well.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I added a picture of a cute animal cause it's fun

@lirantal lirantal added the enhancement New feature or request label Jul 12, 2021
@lirantal lirantal requested a review from Kirill89 July 12, 2021 09:41
@lirantal lirantal self-assigned this Jul 12, 2021
@lirantal lirantal changed the title Feat/cli arguments Feat: cli arguments support and CJS to ESM conversion Jul 12, 2021
@lirantal lirantal merged commit 5fab236 into main Jul 12, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant