Skip to content

Remove Ecommerce Events (close #329) #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove Ecommerce Events (close #329) #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8f7d99
Remove ecommerce events from tracker
Jack-Keene Apr 3, 2023
62514af
Remove ecommerce tests
Jack-Keene Apr 3, 2023
e9eadac
Remove ecommerce unit tests
Jack-Keene Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 0 additions & 76 deletions snowplow_tracker/test/integration/test_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,82 +81,6 @@ def test_integration_page_view(self) -> None:
from_querystring(key, querystrings[-1]), expected_fields[key]
)

def test_integration_ecommerce_transaction_item(self) -> None:
t = tracker.Tracker([get_emitter], default_subject)
with HTTMock(pass_response_content):
t.track_ecommerce_transaction_item(
"12345", "pbz0025", 7.99, 2, "black-tarot", "tarot", currency="GBP"
)
expected_fields = {
"ti_ca": "tarot",
"ti_id": "12345",
"ti_qu": "2",
"ti_sk": "pbz0025",
"e": "ti",
"ti_nm": "black-tarot",
"ti_pr": "7.99",
"ti_cu": "GBP",
}
for key in expected_fields:
self.assertEqual(
from_querystring(key, querystrings[-1]), expected_fields[key]
)

def test_integration_ecommerce_transaction(self) -> None:
t = tracker.Tracker([get_emitter], default_subject)
with HTTMock(pass_response_content):
t.track_ecommerce_transaction(
"6a8078be",
35,
city="London",
currency="GBP",
items=[
{"sku": "pbz0026", "price": 20, "quantity": 1},
{"sku": "pbz0038", "price": 15, "quantity": 1},
],
)

expected_fields = {
"e": "tr",
"tr_id": "6a8078be",
"tr_tt": "35",
"tr_ci": "London",
"tr_cu": "GBP",
}
for key in expected_fields:
self.assertEqual(
from_querystring(key, querystrings[-3]), expected_fields[key]
)

expected_fields = {
"e": "ti",
"ti_id": "6a8078be",
"ti_sk": "pbz0026",
"ti_pr": "20",
"ti_cu": "GBP",
}
for key in expected_fields:
self.assertEqual(
from_querystring(key, querystrings[-2]), expected_fields[key]
)

expected_fields = {
"e": "ti",
"ti_id": "6a8078be",
"ti_sk": "pbz0038",
"ti_pr": "15",
"ti_cu": "GBP",
}
for key in expected_fields:
self.assertEqual(
from_querystring(key, querystrings[-1]), expected_fields[key]
)

self.assertEqual(
from_querystring("ttm", querystrings[-3]),
from_querystring("ttm", querystrings[-2]),
)

def test_integration_mobile_screen_view(self) -> None:
t = tracker.Tracker([get_emitter], default_subject, encode_base64=False)
with HTTMock(pass_response_content):
Expand Down
Loading