fix: export Event#38
Open
Damjan Znidarsic (spinx) wants to merge 3 commits into
Open
Conversation
Contributor
|
Hey, Damjan Znidarsic (@spinx)! Thanks for contributing! In your fix, you are adding another entrypoint to the bundler configuration, which is not precisely correct as there is a risk of exposing some encapsulated entries from that file. That also makes the project structure more brittle if this file gets renamed. The correct way of doing that would be to reexport the interface at the bottom of export type { Event } from './event'; |
Author
|
HI Michael Dokolin (@dokmic), fixed to the correct way now. |
Co-authored-by: Michael Dokolin <dokmic@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exports Event interface so it can be used when doing transformations