Skip to content

fix: export Event#38

Open
Damjan Znidarsic (spinx) wants to merge 3 commits into
snowplow-incubator:masterfrom
spinx:export-interface
Open

fix: export Event#38
Damjan Znidarsic (spinx) wants to merge 3 commits into
snowplow-incubator:masterfrom
spinx:export-interface

Conversation

@spinx

Copy link
Copy Markdown

This exports Event interface so it can be used when doing transformations

@dokmic

Copy link
Copy Markdown
Contributor

Hey, Damjan Znidarsic (@spinx)!

Thanks for contributing!

In your fix, you are adding another entrypoint to the bundler configuration, which is not precisely correct as there is a risk of exposing some encapsulated entries from that file. That also makes the project structure more brittle if this file gets renamed.

The correct way of doing that would be to reexport the interface at the bottom of index.ts:

export type { Event } from './event';

@spinx

Copy link
Copy Markdown
Author

HI Michael Dokolin (@dokmic), fixed to the correct way now.

Comment thread src/index.ts
Co-authored-by: Michael Dokolin <dokmic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants