chore: Remove hardcoded values from documentation#3381
Merged
Conversation
sfc-gh-jmichalak
commented
Feb 5, 2025
sfc-gh-jmichalak
commented
Contributor
- Discourage using hardcoded values by removing them from the examples in resources and the provider. Use TF variables instead.
|
Integration tests cancelled for a198e3203e3fd849d2f9e6924681ef952d81c12a |
sfc-gh-asawicki
requested changes
Feb 6, 2025
|
Integration tests cancelled for e4f8250dfb62a9ee493a7c943454141e0b861ab0 |
|
Integration tests cancelled for 087172290b9c486117d57d3c263e4681a5a223ea |
2 tasks
sfc-gh-asawicki
approved these changes
Feb 7, 2025
sfc-gh-jcieslak
approved these changes
Feb 10, 2025
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Feb 26, 2025
🤖 I have created a release *beep* *boop* --- ## [1.0.4](v1.0.3...v1.0.4) (2025-02-26) ### 🔧 **Misc** * Add GA scope to the roadmap ([#3385](#3385)) ([9be2196](9be2196)) * Adjust saml2_integration documentation ([#3415](#3415)) ([b8c127d](b8c127d)) * Bump Go version ([#3408](#3408)) ([902670e](902670e)) * Bump provider version ([#3419](#3419)) ([552e44b](552e44b)) * Remove hardcoded values from documentation ([#3381](#3381)) ([cb1d6e2](cb1d6e2)) * Update user docs ([#3416](#3416)) ([9d5224f](9d5224f)), closes [#3404](#3404) * Upgrade deps ([#3389](#3389)) ([086bf15](086bf15)) ### 🐛 **Bug fixes:** * account for null comment ([#3417](#3417)) ([2f7f80f](2f7f80f)) * external function varchar return type validation ([#3400](#3400)) ([abf5883](abf5883)) * Fix managed account and adjust account ticket numbers ([#3395](#3395)) ([a7cb5cb](a7cb5cb)) * Propose changes to assertions setup with varying test client ([#3406](#3406)) ([fb27f6a](fb27f6a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.