Skip to content

Conversation

sfc-gh-heshah
Copy link
Collaborator

@sfc-gh-heshah sfc-gh-heshah commented Sep 17, 2025

  1. What Jira ticket or GitHub issue is this PR addressing? Make sure that there is a ticket or issue accompanying your PR.

    Fixes SNOW-2343819.

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Need .sha256 checksum files for released artifacts as well. Updating deploy scripts to do so. See

Copy link
Collaborator Author

@sfc-gh-heshah sfc-gh-heshah marked this pull request as ready for review September 17, 2025 20:40
@sfc-gh-heshah sfc-gh-heshah force-pushed the heshah-SNOW-2343819-consolidate-common-deploy-functionality-generate-sha256-checksum-files-in-deploy-scripts branch from ee97715 to 8cf5953 Compare September 17, 2025 20:41
Copy link
Collaborator

@sfc-gh-bli sfc-gh-bli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator Author

sfc-gh-heshah commented Sep 17, 2025

Merge activity

  • Sep 17, 10:35 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Sep 17, 10:35 PM UTC: @sfc-gh-heshah merged this pull request with Graphite.

@sfc-gh-heshah sfc-gh-heshah merged commit c97ee67 into main Sep 17, 2025
48 of 50 checks passed
@sfc-gh-heshah sfc-gh-heshah deleted the heshah-SNOW-2343819-consolidate-common-deploy-functionality-generate-sha256-checksum-files-in-deploy-scripts branch September 17, 2025 22:35
sfc-gh-bli pushed a commit that referenced this pull request Sep 17, 2025
…6 checksum files in deploy scripts (#245)

1. What Jira ticket or GitHub issue is this PR addressing? Make sure that there is a ticket or issue accompanying your PR.

   Fixes SNOW-2343819. 

2. Fill out the following pre-review checklist:

   - [ ] I am adding a new automated test(s) to verify correctness of my new code
   - [ ] I am adding new logging messages
   - [ ] I am adding a new telemetry message
   - [ ] I am adding new credentials
   - [ ] I am adding a new dependency

3. Please describe how your code solves the related issue.

   Need `.sha256` checksum files for released artifacts as well. Updating deploy scripts to do so. See
     - https://snowflake.slack.com/archives/C054J469AN4/p1758085517918489
     - snowflakedb/snowflake#337992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants