Skip to content

SNOW-2339275: fix FIPS tests #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

SNOW-2339275: fix FIPS tests #244

merged 1 commit into from
Sep 17, 2025

Conversation

sfc-gh-heshah
Copy link
Collaborator

@sfc-gh-heshah sfc-gh-heshah commented Sep 16, 2025 •
edited
Loading

  1. What Jira ticket or GitHub issue is this PR addressing? Make sure that there is a ticket or issue accompanying your PR.

    Fixes SNOW-2339275

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Adding FIPS BouncyCastle libraries needed for test set up to work.

@sfc-gh-heshah Graphite App
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sfc-gh-heshah sfc-gh-heshah marked this pull request as ready for review September 16, 2025 23:21
@sfc-gh-heshah sfc-gh-heshah force-pushed the heshah-SNOW-2339275-fix-FIPS-tests branch from fe8eae0 to b22dacb Compare September 17, 2025 01:04
sfc-gh-bli
sfc-gh-bli approved these changes Sep 17, 2025
View reviewed changes
Copy link
Collaborator

@sfc-gh-bli sfc-gh-bli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-bli sfc-gh-bli merged commit 94c75ab into main Sep 17, 2025
27 checks passed
@sfc-gh-bli sfc-gh-bli deleted the heshah-SNOW-2339275-fix-FIPS-tests branch September 17, 2025 03:24
sfc-gh-bli pushed a commit that referenced this pull request Sep 17, 2025
@sfc-gh-heshah @sfc-gh-bli
SNOW-2339275: fix FIPS tests (#244)
58919ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-bli sfc-gh-bli sfc-gh-bli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-heshah @sfc-gh-bli