Compile the 'on' clause of a merge into statement #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attempting converting to draft and back to trigger reviews |
TRManderson
requested review from
sfc-gh-kwagner and
sfc-gh-mkeller
as code owners
TRManderson
force-pushed
the
merge-into-on
branch
from
1a6759f to
8366d56
Compare
|
I'm extremely sure that the check failing here is due to misconfiguration, not my code, but there are no new changes on master that I can merge in to trigger a new test run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a use case where my on clause made use of
sqlalchemy.funcand thus had a bind param in it, and without getting the compiler to process theonclause before compiling it, it would have a dangling bind param that was never filled.This fixes my use case. I was not able to run tests because I got a tox error on my mac, so I'm leaving it up to CI (sorry), but all my other Snowflake SQLA code works great with this fix.