SNOW-1374896: return toString result for getObject called on structured types #1945
+165
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-mkubik
changed the title
…ormat ARROW is set
| .collect( | ||
| Collectors.toMap( | ||
| entry -> entry.get("key").toString(), entry -> entry.get("value"))); | ||
| return isNull(index) ? null : new StructObject(toString(index), map); |
There was a problem hiding this comment.
can we return null before processing entries?
| return entriesList.stream() | ||
| .collect( | ||
| Collectors.toMap(entry -> entry.get("key").toString(), entry -> entry.get("value"))); | ||
| Map map = |
There was a problem hiding this comment.
let's add generics
| Map<String, T> resultMap = new HashMap<>(); | ||
| for (Map.Entry<String, Object> entry : map.entrySet()) { | ||
| if (SQLData.class.isAssignableFrom(type)) { | ||
| SQLData instance = (SQLData) SQLDataCreationHelper.create(type); | ||
| SQLInput sqlInput = | ||
| sfBaseResultSet.createSqlInputForColumn( | ||
| entry.getValue(), | ||
| object.getClass(), | ||
| object.getObject().getClass(), |
There was a problem hiding this comment.
object.getObject() looks strange - can we rename variable?
| } else if (object instanceof StructObject) { | ||
| return ((StructObject) object).getStringJson(); | ||
| } else if (object instanceof SfSqlArray) { | ||
| return ((SfSqlArray) object).getJsonString(); |
There was a problem hiding this comment.
can we decide to have method getStringJson or getJsonString?
| @@ -62,6 +62,15 @@ public void testRunAsGetString() throws SQLException { | |||
| (resultSet) -> assertGetStringIsCompatible(resultSet, expectedStructureTypeRepresentation)); | |||
| } | |||
|
|
|||
| @Test | |||
| @ConditionalIgnoreRule.ConditionalIgnore(condition = RunningOnGithubAction.class) | |||
There was a problem hiding this comment.
we still cannot run tests on Github?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNOW-1374896
Turns out that backward compatibility with JSON structured types may also require support for getObject and getBytes methods.
This PR adds JSON/ARROW compatibility for getObject
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX: